aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorValentin Bartenev <vbart@nginx.com>2016-06-16 20:55:11 +0300
committerValentin Bartenev <vbart@nginx.com>2016-06-16 20:55:11 +0300
commit24d9b98900a5318778dcab3f765e85a8bed5d136 (patch)
treef1c3aaa5692befe5fdc8dd08151196d3afdeb193 /src
parentab8504b937cdbae734fb2d971fba4eea0b157f43 (diff)
downloadnginx-24d9b98900a5318778dcab3f765e85a8bed5d136.tar.gz
nginx-24d9b98900a5318778dcab3f765e85a8bed5d136.zip
HTTP/2: fixed a segfault while processing unbuffered upload.
The ngx_http_v2_finalize_connection() closes current stream, but that is an invalid operation while processing unbuffered upload. This results in access to already freed memory, since the upstream module sets a cleanup handler that also finalizes the request.
Diffstat (limited to 'src')
-rw-r--r--src/http/v2/ngx_http_v2.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/src/http/v2/ngx_http_v2.c b/src/http/v2/ngx_http_v2.c
index 208f0f325..94f57a717 100644
--- a/src/http/v2/ngx_http_v2.c
+++ b/src/http/v2/ngx_http_v2.c
@@ -4169,10 +4169,6 @@ ngx_http_v2_finalize_connection(ngx_http_v2_connection_t *h2c,
c->error = 1;
- if (h2c->state.stream) {
- ngx_http_v2_close_stream(h2c->state.stream, NGX_HTTP_BAD_REQUEST);
- }
-
if (!h2c->processing) {
ngx_http_close_connection(c);
return;