diff options
| author | Valentin Bartenev <vbart@nginx.com> | 2016-11-28 19:19:21 +0300 |
|---|---|---|
| committer | Valentin Bartenev <vbart@nginx.com> | 2016-11-28 19:19:21 +0300 |
| commit | 89f92b32430c1df2a25580d15f1b047cde8fb792 (patch) | |
| tree | 2a9ac1b27f788dd1399ea0f24f76139bda1e6320 | |
| parent | 4c6e31a8577087561cefbed86cf9771604794b8c (diff) | |
| download | nginx-89f92b32430c1df2a25580d15f1b047cde8fb792.tar.gz nginx-89f92b32430c1df2a25580d15f1b047cde8fb792.zip | |
HTTP/2: fixed saving preread buffer to temp file (ticket #1143).
Previously, a request body bigger than "client_body_buffer_size" wasn't written
into a temporary file if it has been pre-read entirely. The preread buffer
is freed after processing, thus subsequent use of it might result in sending
corrupted body or cause a segfault.
| -rw-r--r-- | src/http/v2/ngx_http_v2.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/http/v2/ngx_http_v2.c b/src/http/v2/ngx_http_v2.c index 83016304a..485f735d9 100644 --- a/src/http/v2/ngx_http_v2.c +++ b/src/http/v2/ngx_http_v2.c @@ -3575,6 +3575,9 @@ ngx_http_v2_read_request_body(ngx_http_request_t *r, rb->buf = ngx_create_temp_buf(r->pool, (size_t) len); } else { + /* enforce writing body to file */ + r->request_body_in_file_only = 1; + rb->buf = ngx_calloc_buf(r->pool); if (rb->buf != NULL) { |