From a1b2f0344a59e24ae4d16f1689a02ba72ced2b53 Mon Sep 17 00:00:00 2001 From: Kero van Gelder Date: Wed, 5 Apr 2023 14:33:00 +0200 Subject: =?UTF-8?q?=F0=9F=90=9B=20Avoid=20a=20race=20condition=20when=20di?= =?UTF-8?q?spatch=20is=20used=20twice=20from=20outside=20(#8)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Upgrade examples to lustre 2.0 * Upgrade to gleam 0.27.0 * Fix: avoid a race condition when dispatch is used twice from outside E.g. websocket open + websocket msg arriving Application returns a Cmd from update(model, msg) but the Effect handler is *not* ran be React 18 before the websocket msg-arriving is handled by the Reducer. Result: The Cmd returned by update(model, msg) is dropped silently. --------- Co-authored-by: Kero van Gelder --- test/playground/monaco.gleam | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'test/playground') diff --git a/test/playground/monaco.gleam b/test/playground/monaco.gleam index f0927ca..14958ac 100644 --- a/test/playground/monaco.gleam +++ b/test/playground/monaco.gleam @@ -8,7 +8,7 @@ pub external fn render (attributes: List(Attribute(action))) -> Element(action) pub fn on_change (handler: fn (String, fn (action) -> Nil) -> Nil) -> Attribute(action) { event.on("change", fn (e, dispatch) { - assert Ok(code) = dynamic.string(e) + let assert Ok(code) = dynamic.string(e) handler(code, dispatch) }) -- cgit v1.2.3