From 8f9d8b1969270d0786cd4eeb369ed3d42a62e541 Mon Sep 17 00:00:00 2001
From: sobolevn <mail@sobolevn.me>
Date: Mon, 19 Aug 2024 22:50:02 +0300
Subject: Address review

---
 test/gleam/bit_array_test.gleam | 37 ++++++++++++++++++++++++++++++++-----
 1 file changed, 32 insertions(+), 5 deletions(-)

(limited to 'test')

diff --git a/test/gleam/bit_array_test.gleam b/test/gleam/bit_array_test.gleam
index 56b6bf5..38dcb2e 100644
--- a/test/gleam/bit_array_test.gleam
+++ b/test/gleam/bit_array_test.gleam
@@ -389,11 +389,26 @@ pub fn compare_utf16_test() {
   |> should.equal(order.Lt)
 }
 
+@target(erlang)
+pub fn compare_utf32_test() {
+  bit_array.compare(<<"ABC":utf32>>, <<"ABC":utf32>>)
+  |> should.equal(order.Eq)
+
+  bit_array.compare(<<"ABC":utf32>>, <<"AB":utf32>>)
+  |> should.equal(order.Gt)
+
+  bit_array.compare(<<"A":utf32>>, <<"Z":utf32>>)
+  |> should.equal(order.Lt)
+}
+
 @target(erlang)
 pub fn compare_mixed_utfs_test() {
   bit_array.compare(<<"A":utf16>>, <<"A":utf8>>)
   |> should.equal(order.Lt)
 
+  bit_array.compare(<<"A":utf32>>, <<"A":utf16>>)
+  |> should.equal(order.Lt)
+
   bit_array.compare(<<"A":utf8>>, <<"A":utf16>>)
   |> should.equal(order.Gt)
 
@@ -403,11 +418,20 @@ pub fn compare_mixed_utfs_test() {
   bit_array.compare(<<"":utf16>>, <<"A":utf8>>)
   |> should.equal(order.Lt)
 
+  bit_array.compare(<<"":utf32>>, <<"A":utf8>>)
+  |> should.equal(order.Lt)
+
+  bit_array.compare(<<"":utf32>>, <<"A":utf16>>)
+  |> should.equal(order.Lt)
+
   bit_array.compare(<<"":utf16>>, <<"":utf8>>)
   |> should.equal(order.Eq)
 
   bit_array.compare(<<"":utf8>>, <<"":utf16>>)
   |> should.equal(order.Eq)
+
+  bit_array.compare(<<"":utf8>>, <<"":utf32>>)
+  |> should.equal(order.Eq)
 }
 
 @target(erlang)
@@ -416,19 +440,22 @@ pub fn compare_different_sizes_test() {
   |> should.equal(order.Eq)
 
   bit_array.compare(<<3:5>>, <<4:5>>)
-  |> should.equal(order.Eq)
+  |> should.equal(order.Lt)
+
+  bit_array.compare(<<3:7>>, <<4:7>>)
+  |> should.equal(order.Lt)
 
   bit_array.compare(<<5:5>>, <<4:5>>)
-  |> should.equal(order.Eq)
+  |> should.equal(order.Gt)
 
   bit_array.compare(<<4:8>>, <<4:5>>)
-  |> should.equal(order.Gt)
+  |> should.equal(order.Eq)
 
   bit_array.compare(<<4:5>>, <<4:8>>)
-  |> should.equal(order.Lt)
+  |> should.equal(order.Eq)
 
   bit_array.compare(<<0:5>>, <<0:8>>)
-  |> should.equal(order.Lt)
+  |> should.equal(order.Eq)
 
   bit_array.compare(<<0:2>>, <<0:1>>)
   |> should.equal(order.Eq)
-- 
cgit v1.2.3