From 2f3b2bbaf925c432f0fc128336c4e62b7c9d34a9 Mon Sep 17 00:00:00 2001
From: Richard Viney <richard.viney@gmail.com>
Date: Fri, 29 Nov 2024 09:53:00 +1300
Subject: Optimise dict equality check on JavaScript

---
 src/dict.mjs | 24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)

(limited to 'src')

diff --git a/src/dict.mjs b/src/dict.mjs
index 950037e..472d63d 100644
--- a/src/dict.mjs
+++ b/src/dict.mjs
@@ -968,10 +968,24 @@ export default class Dict {
     if (!(o instanceof Dict) || this.size !== o.size) {
       return false;
     }
-    let equal = true;
-    this.forEach((v, k) => {
-      equal = equal && isEqual(o.get(k, !v), v);
-    });
-    return equal;
+
+    try {
+      this.forEach((v, k) => {
+        if (!isEqual(o.get(k, !v), v)) {
+          throw unequalDictSymbol;
+        }
+      });
+      return true;
+    } catch (e) {
+      if (e === unequalDictSymbol) {
+        return false;
+      }
+
+      throw e;
+    }
   }
 }
+
+// This is thrown internally in Dict.equals() so that it returns false as soon
+// as a non-matching key is found
+const unequalDictSymbol = Symbol();
-- 
cgit v1.2.3