aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLouis Pilfold <louis@lpil.uk>2024-04-04 11:08:43 +0100
committerLouis Pilfold <louis@lpil.uk>2024-04-04 11:08:43 +0100
commitd40649249ef2c294054ff741a0a2864bf4850968 (patch)
tree9e6c01b8bb04c2b04c5b3a265ecf5f5ff3486d6b
parent5ffdec6ad30ce5e27b96fe3133b832e61b72b909 (diff)
downloadgleam_stdlib-d40649249ef2c294054ff741a0a2864bf4850968.tar.gz
gleam_stdlib-d40649249ef2c294054ff741a0a2864bf4850968.zip
Fix test and warnings
-rw-r--r--CHANGELOG.md2
-rw-r--r--src/gleam_stdlib.mjs2
-rw-r--r--test/gleam/dynamic_test.gleam6
-rw-r--r--test/gleam/string_test.gleam29
4 files changed, 11 insertions, 28 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index e74c531..a756cc7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,7 +7,7 @@
misused, resulting in poor code.
- `list.LengthMismatch` has been removed.
- The mistakenly public `bit_array.do_inspect` function has been removed.
-- Fixed the `dynamic.classification` function for boolean values.
+- Fixed the `dynamic.classification` function for bools.
## v0.36.0 - 2024-02-26
diff --git a/src/gleam_stdlib.mjs b/src/gleam_stdlib.mjs
index 821782d..40fcc3f 100644
--- a/src/gleam_stdlib.mjs
+++ b/src/gleam_stdlib.mjs
@@ -498,6 +498,8 @@ export function decode64(sBase64) {
export function classify_dynamic(data) {
if (typeof data === "string") {
return "String";
+ } else if (typeof data === "boolean") {
+ return "Bool";
} else if (data instanceof Result) {
return "Result";
} else if (data instanceof List) {
diff --git a/test/gleam/dynamic_test.gleam b/test/gleam/dynamic_test.gleam
index 5f22c9e..4b6c797 100644
--- a/test/gleam/dynamic_test.gleam
+++ b/test/gleam/dynamic_test.gleam
@@ -1,5 +1,5 @@
-import gleam/dynamic.{DecodeError}
import gleam/dict
+import gleam/dynamic.{DecodeError}
import gleam/option.{None, Some}
import gleam/result
import gleam/should
@@ -1505,10 +1505,6 @@ pub fn decode9_test() {
)
}
-type ClassifyAtom {
- ClassifyAtom
-}
-
pub fn classify_test() {
dynamic.from(True)
|> dynamic.classify
diff --git a/test/gleam/string_test.gleam b/test/gleam/string_test.gleam
index bb3f502..684bc1b 100644
--- a/test/gleam/string_test.gleam
+++ b/test/gleam/string_test.gleam
@@ -1,5 +1,5 @@
-import gleam/option.{None, Some}
import gleam/dict
+import gleam/option.{None, Some}
import gleam/order
import gleam/should
import gleam/string
@@ -846,31 +846,16 @@ pub fn inspect_test() {
string.inspect(fn() { Nil })
|> should.equal("//fn() { ... }")
- string.inspect(fn(a) {
- a
- Nil
- })
+ string.inspect(fn(_) { Nil })
|> should.equal("//fn(a) { ... }")
- string.inspect(fn(a, b) {
- a
- b
- Nil
- })
+ string.inspect(fn(_, _) { Nil })
|> should.equal("//fn(a, b) { ... }")
- string.inspect(fn(x, y) {
- x
- y
- Nil
- })
+ string.inspect(fn(_, _) { Nil })
|> should.equal("//fn(a, b) { ... }")
- string.inspect(fn(foo: Int, bar: String) -> Bool {
- foo
- bar
- False
- })
+ string.inspect(fn(_: Int, _: String) -> Bool { False })
|> should.equal("//fn(a, b) { ... }")
string.inspect(#(InspectTypeOne, InspectTypeTwo))
@@ -916,9 +901,9 @@ pub fn target_inspect_test() {
}
@target(erlang)
-import gleam/regex
-@target(erlang)
import gleam/dynamic.{type Dynamic}
+@target(erlang)
+import gleam/regex
// Test inspect on Erlang atoms valid and invalid in Gleam